[beam] branch master updated: Update the spec for extract_output and make it clear the input accumulator is mutable

[altay]

This is an automated email from the ASF dual-hosted git repository.

altay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 0100149  Update the spec for extract_output and make it clear the 
input accumulator is mutable
     new cc903a4  Merge pull request #8264 from robinyqiu/typo
0100149 is described below

commit 0100149c44bf07c9ac8dc93fde44289d97d2ede5
Author: Yueyang Qiu <robiny...@gmail.com>
AuthorDate: Tue Apr 9 15:03:41 2019 -0700

    Update the spec for extract_output and make it clear the input accumulator 
is mutable
---
 .../core/src/main/java/org/apache/beam/sdk/transforms/Combine.java     | 2 ++
 sdks/python/apache_beam/transforms/core.py                             | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java 
b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
index 54e6f08..7444062 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
@@ -359,6 +359,8 @@ public class Combine {
     /**
      * Returns the output value that is the result of combining all the input 
values represented by
      * the given accumulator.
+     *
+     * @param accumulator can be modified for efficiency
      */
     public abstract OutputT extractOutput(AccumT accumulator);
 
diff --git a/sdks/python/apache_beam/transforms/core.py 
b/sdks/python/apache_beam/transforms/core.py
index a445152..a159abd 100644
--- a/sdks/python/apache_beam/transforms/core.py
+++ b/sdks/python/apache_beam/transforms/core.py
@@ -667,7 +667,8 @@ class CombineFn(WithTypeHints, HasDisplayData, 
urns.RunnerApiFn):
 
     Args:
       accumulator: the final accumulator value computed by this CombineFn
-        for the entire input key or PCollection.
+        for the entire input key or PCollection. Can be modified for
+        efficiency.
       *args: Additional arguments and side inputs.
       **kwargs: Additional arguments and side inputs.
     """