This is an automated email from the ASF dual-hosted git repository.
pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 95717fa [BEAM-8228] Changed suffix of Dataflow counter metrics names
filtered after adding distribution metric
new f9a95cd Merge pull request #9564 from
kkucharc/BEAM-8228-change-counter-metrics-suffix-filter
95717fa is described below
commit 95717faf9b4330d5a2fedba25b847ea8f9acde41
Author: Kasia Kucharczyk <[email protected]>
AuthorDate: Fri Sep 13 13:16:21 2019 +0200
[BEAM-8228] Changed suffix of Dataflow counter metrics names filtered after
adding distribution metric
---
sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
b/sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
index 741e944..3a07e65 100644
--- a/sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
+++ b/sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
@@ -154,14 +154,14 @@ class DataflowMetrics(MetricResults):
# Get the tentative/committed versions of every metric together.
metrics_by_name = defaultdict(lambda: {})
for metric in metrics:
- if (metric.name.name.endswith('[MIN]') or
- metric.name.name.endswith('[MAX]') or
- metric.name.name.endswith('[MEAN]') or
- metric.name.name.endswith('[COUNT]')):
+ if (metric.name.name.endswith('_MIN') or
+ metric.name.name.endswith('_MAX') or
+ metric.name.name.endswith('_MEAN') or
+ metric.name.name.endswith('_COUNT')):
# The Dataflow Service presents distribution metrics in two ways:
# One way is as a single distribution object with all its fields, and
- # another way is as four different scalar metrics labeled as [MIN],
- # [MAX], [COUNT], [MEAN].
+ # another way is as four different scalar metrics labeled as _MIN,
+ # _MAX, _COUNT_, _MEAN.
# TODO(pabloem) remove these when distributions are not being broken up
# in the service.
# The second way is only useful for the UI, and should be ignored.
