This is an automated email from the ASF dual-hosted git repository.
mikhail pushed a commit to branch release-2.17.0
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/release-2.17.0 by this push:
new c0fbfb2 Remove base tests from python precommits
new b77f2c3 Merge pull request #10197 from
tvalentyn/cp_precommit_improvements
c0fbfb2 is described below
commit c0fbfb268365fe767b04d6733e1579e670b87538
Author: Ahmet Altay <[email protected]>
AuthorDate: Mon Nov 4 13:46:35 2019 -0800
Remove base tests from python precommits
GCP and Cython test variants provide the same coverage and also ensure
that test could run with or without GCP or Cython components intalled.
---
sdks/python/test-suites/tox/py2/build.gradle | 2 +-
sdks/python/test-suites/tox/py35/build.gradle | 2 +-
sdks/python/test-suites/tox/py36/build.gradle | 1 -
sdks/python/test-suites/tox/py37/build.gradle | 1 -
4 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/sdks/python/test-suites/tox/py2/build.gradle
b/sdks/python/test-suites/tox/py2/build.gradle
index 867c33e..7928405 100644
--- a/sdks/python/test-suites/tox/py2/build.gradle
+++ b/sdks/python/test-suites/tox/py2/build.gradle
@@ -40,6 +40,7 @@ test.dependsOn testPython2
toxTask "testPy2Cython", "py27-cython"
test.dependsOn testPy2Cython
+
// Ensure that testPy2Cython runs exclusively to other tests. This line is not
// actually required, since gradle doesn't do parallel execution within a
// project.
@@ -53,6 +54,5 @@ toxTask "cover", "cover"
task preCommitPy2() {
dependsOn "docs"
dependsOn "testPy2Cython"
- dependsOn "testPython2"
dependsOn "testPy2Gcp"
}
diff --git a/sdks/python/test-suites/tox/py35/build.gradle
b/sdks/python/test-suites/tox/py35/build.gradle
index 9c535b9..2a496e3 100644
--- a/sdks/python/test-suites/tox/py35/build.gradle
+++ b/sdks/python/test-suites/tox/py35/build.gradle
@@ -34,13 +34,13 @@ test.dependsOn testPy35Gcp
toxTask "testPy35Cython", "py35-cython"
test.dependsOn testPy35Cython
+
// Ensure that testPy35Cython runs exclusively to other tests. This line is not
// actually required, since gradle doesn't do parallel execution within a
// project.
testPy35Cython.mustRunAfter testPython35, testPy35Gcp
task preCommitPy35() {
- dependsOn "testPython35"
dependsOn "testPy35Gcp"
dependsOn "testPy35Cython"
}
diff --git a/sdks/python/test-suites/tox/py36/build.gradle
b/sdks/python/test-suites/tox/py36/build.gradle
index 649436f..7ff966c 100644
--- a/sdks/python/test-suites/tox/py36/build.gradle
+++ b/sdks/python/test-suites/tox/py36/build.gradle
@@ -40,7 +40,6 @@ test.dependsOn testPy36Cython
testPy36Cython.mustRunAfter testPython36, testPy36Gcp
task preCommitPy36() {
- dependsOn "testPython36"
dependsOn "testPy36Gcp"
dependsOn "testPy36Cython"
}
diff --git a/sdks/python/test-suites/tox/py37/build.gradle
b/sdks/python/test-suites/tox/py37/build.gradle
index 25274d2..8fed456 100644
--- a/sdks/python/test-suites/tox/py37/build.gradle
+++ b/sdks/python/test-suites/tox/py37/build.gradle
@@ -46,7 +46,6 @@ test.dependsOn testPy37Cython
testPy37Cython.mustRunAfter testPython37, testPy37Gcp
task preCommitPy37() {
- dependsOn "testPython37"
dependsOn "testPy37Gcp"
dependsOn "testPy37Cython"
}