This is an automated email from the ASF dual-hosted git repository. pabloem pushed a commit to branch pabloem-patch-1 in repository https://gitbox.apache.org/repos/asf/beam.git
commit 2c3f9c44ae43e321402ae424f4b3ba31ebbe7849 Author: Pablo <[email protected]> AuthorDate: Fri Jan 31 16:06:53 2020 -0800 No longer reporting Lulls as errors in the worker. --- .../dataflow/worker/StreamingModeExecutionContext.java | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java index a761ae4..e4ee16c 100644 --- a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java +++ b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java @@ -147,19 +147,6 @@ public class StreamingModeExecutionContext extends DataflowExecutionContext<Step this.worker = worker; } - /* - * Report the lull to the StreamingDataflowWorker that is stuck in addition to logging the - * lull. - */ - @Override - public void reportLull(Thread trackedThread, long millis) { - super.reportLull(trackedThread, millis); - // Also report the failure to the list of pending failures to report on the worker thread - // so that the failure gets communicated to the StreamingDataflowWorker. - String errorMessage = getLullMessage(trackedThread, Duration.millis(millis)); - worker.addFailure(errorMessage); - } - /** * Take sample is only called by the ExecutionStateSampler thread. It is the only place that * increments totalMillisInState, however the reporting thread periodically calls extractUpdate
