robertwb commented on a change in pull request #10822: [BEAM-7746] Minor typing
updates / fixes
URL: https://github.com/apache/beam/pull/10822#discussion_r384665851
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -1289,9 +1289,9 @@ class RestrictionProgress(object):
"""
def __init__(self, **kwargs):
# Only accept keyword arguments.
- self._fraction = kwargs.pop('fraction', None)
- self._completed = kwargs.pop('completed', None)
- self._remaining = kwargs.pop('remaining', None)
+ self._fraction = kwargs.pop('fraction', None) # type: Optional[float]
+ self._completed = kwargs.pop('completed', None) # type: Optional[int]
Review comment:
I don't know that we want to restrict this to integral values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
