lukecwik commented on a change in pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r384702356
########## File path: sdks/python/apache_beam/testing/test_stream.py ########## @@ -171,13 +184,20 @@ class TestStream(PTransform): time. After all of the specified elements are emitted, ceases to produce output. """ - def __init__(self, coder=coders.FastPrimitivesCoder(), events=None): + def __init__( Review comment: Please add pydoc comments mentioning the few important pieces: 1) specifying the output_tags allows for adding outputs that produce no events 2) output_tags must be a superset of tags found in events if events is specified ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
