chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging
artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r384729053
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -261,14 +263,20 @@ public String registerCoder(Coder<?> coder) throws
IOException {
* return the same unique ID.
*/
public String registerEnvironment(Environment env) {
+ String environmentId;
String existing = environmentIds.get(env);
if (existing != null) {
- return existing;
+ environmentId = existing;
+ } else {
+ String name = uniqify(env.getUrn(), environmentIds.values());
+ environmentIds.put(env, name);
+ componentsBuilder.putEnvironments(name, env);
+ environmentId = name;
}
- String name = uniqify(env.getUrn(), environmentIds.values());
- environmentIds.put(env, name);
- componentsBuilder.putEnvironments(name, env);
- return name;
+ if (defaultEnvironmentId == null) {
Review comment:
Probably it's better to explicitly declare the given environment as the
default (through an additional argument to registerEnvironment()) instead of
assuming first one that was passed to here to be the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
