robertwb commented on a change in pull request #10621: [BEAM-9056] Staging
artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r384853067
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -331,22 +389,23 @@ def _download_file(from_url, to_path):
def _is_remote_path(path):
return path.find('://') != -1
- def _stage_jar_packages(self, jar_packages, staging_location, temp_dir):
- # type: (...) -> List[str]
+ @staticmethod
+ def _stage_jar_packages(jar_packages, temp_dir):
Review comment:
Does this actually stage them, or just add them to the returned list? If
not, the name and docstring should be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
