lukecwik commented on a change in pull request #10897: [BEAM-2939] Java
UnboundedSource SDF wrapper
URL: https://github.com/apache/beam/pull/10897#discussion_r384867760
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -375,4 +422,361 @@ public void checkDone() throws IllegalStateException {
}
}
}
+
+ /**
+ * A splittable {@link DoFn} which executes an {@link UnboundedSource}.
+ *
+ * <p>We model the element as the original source and the restriction as a
pair of the sub-source
+ * and its {@link CheckpointMark}. This allows us to split the sub-source
over and over as long as
+ * the checkpoint mark is {@code null} or the {@link NoopCheckpointMark}
since it does not
+ * maintain any state.
+ */
+ // TODO: Support reporting the watermark, currently the watermark never
advances.
Review comment:
Will file JIRA if I can't do all the watermark reporting passing and
implementation in the SDK harness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
