alexvanboxel commented on a change in pull request #10883: [BEAM-9331] Add
better Row builders
URL: https://github.com/apache/beam/pull/10883#discussion_r384969152
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/values/RowTest.java
##########
@@ -477,6 +477,172 @@ public void testCreateMapWithRowValue() {
assertEquals(data, row.getMap("map"));
}
+ @Test
Review comment:
I propose to take this discussion out of this PR, as I really like this
already. For me it's already a LGTM. (Best to wait till the 2.20 is cut though).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
