amaliujia commented on a change in pull request #10967: [BEAM-9300] convert
struct literal in ZetaSQL
URL: https://github.com/apache/beam/pull/10967#discussion_r385394145
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java
##########
@@ -222,6 +222,14 @@ public void unparseCall(
}
writer.endFunCall(frame);
break;
+ case ROW:
Review comment:
nit: ideally such `unparse` should happen within `operator` classes. But
since we implement it in Beam it is just ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
