ibzib commented on a change in pull request #10967: [BEAM-9300] convert struct 
literal in ZetaSQL
URL: https://github.com/apache/beam/pull/10967#discussion_r385396445
 
 

 ##########
 File path: 
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java
 ##########
 @@ -222,6 +222,14 @@ public void unparseCall(
         }
         writer.endFunCall(frame);
         break;
+      case ROW:
 
 Review comment:
   I thought about replacing 
[`SqlRowOperator`](https://calcite.apache.org/apidocs/org/apache/calcite/sql/fun/SqlRowOperator.html)
 with our own custom operator. But I like this better, because it only 
overrides unparsing without affecting the rest of the operator code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to