pabloem commented on a change in pull request #10497: [BEAM-8335] Add the
ReverseTestStream
URL: https://github.com/apache/beam/pull/10497#discussion_r385984734
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -421,8 +424,12 @@ def process_element(self, element):
main_output = list(self._outputs)[0]
bundle = self._evaluation_context.create_bundle(main_output)
for tv in event.timestamped_values:
- bundle.output(
- GlobalWindows.windowed_value(tv.value, timestamp=tv.timestamp))
+ # Unreify the value into the correct window.
+ try:
+ bundle.output(WindowedValue(**tv.value))
+ except TypeError:
+ bundle.output(
+ GlobalWindows.windowed_value(tv.value, timestamp=tv.timestamp))
Review comment:
Question:
What happens if tv.value is a dict from the upstream pcollection?
We are supposing that it's a dict containing the window, pane info, value,
and tstamp OR if we get a typeerror, then it's not a dict, it's only the
element itself - but what if the element itself is a dict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
