kanterov commented on a change in pull request #11015: [BEAM-9424] Allow
grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#discussion_r386873928
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java
##########
@@ -373,6 +376,45 @@ public void testNullInnerRow() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(2));
}
+ @Test
+ public void testLogicalTypes() {
+ Schema beamSchemaWithLogicalTypes =
+ BigQueryUtils.fromTableSchema(
Review comment:
Is it possible to use `DummySqlTimeType` and `DummySqlDateType` as in other
tests? I find dependency on gcp-io not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
