robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the 
StreamingCache to subclass the CacheManager 
URL: https://github.com/apache/beam/pull/11005#discussion_r387258635
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/direct_runner.py
 ##########
 @@ -399,6 +395,15 @@ def visit_transform(self, applied_ptransform):
     self.consumer_tracking_visitor = ConsumerTrackingPipelineVisitor()
     pipeline.visit(self.consumer_tracking_visitor)
 
+    test_stream_service_endpoint = \
 
 Review comment:
   Avoid backslashes for continuation. If needed, use ()'s (or just let yapf do 
it). (Creating the stub here seems a violation of encapsulation though, best to 
do it where it's used.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to