KevinGG commented on a change in pull request #11020: [BEAM-7926] Update Data
Visualization
URL: https://github.com/apache/beam/pull/11020#discussion_r387285131
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -86,10 +85,57 @@ def capture_duration(self, value):
# The next PCollection evaluation will capture fresh data from sources,
# and the data captured will be replayed until another eviction.
"""
+ assert value.total_seconds() > 0, 'Duration must be a positive value.'
self.capture_control._capture_duration = value
# TODO(BEAM-8335): add capture_size options when they are supported.
+ @property
+ def display_timestamp_format(self):
+ """The format in which timestamps are displayed.
+
+ Default is '%Y-%m-%d %H:%M:%S.%f%z', e.g. 2020-02-01 15:05:06.000015-08:00.
Review comment:
docstrings in this module are for notebook users. So keeping them here
allows `Shift+Tab` in notebooks to invoke the docstrings pop up. They function
as in-notebook user guide.
The default is defined in the `interactive_options` module where we hide the
implementation details that are not exposed APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
