alexvanboxel commented on issue #10943: [BEAM-9360] Fix equivalence check for FieldType URL: https://github.com/apache/beam/pull/10943#issuecomment-594599322 > @alexvanboxel problem is not with proto extensions. Proto extension just did uncover the bug because it uses filed metadata. > > What kind of test do you have in mind to put there? If you are sure this fix, fixes your problem that you discovered with protobuf vs the convert then I'm ok with this. If **not** maybe make a small test that replicates the thing you did. It's your call, I see you have a test so it's ok.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
