reuvenlax commented on a change in pull request #10413: [BEAM-9035] Typed 
options for Row Schema and Field
URL: https://github.com/apache/beam/pull/10413#discussion_r387968550
 
 

 ##########
 File path: model/pipeline/src/main/proto/schema.proto
 ##########
 @@ -31,6 +31,7 @@ option java_outer_classname = "SchemaApi";
 message Schema {
   repeated Field fields = 1;
   string id = 2;
+  map<string, Option> options = 3;
 
 Review comment:
   This fields redundant since Option already contains a name. Maybe just make 
repeated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to