aaltay commented on a change in pull request #11050: [BEAM-8335] Implemented Capture Size limitation URL: https://github.com/apache/beam/pull/11050#discussion_r388046153
########## File path: sdks/python/apache_beam/runners/interactive/background_caching_job.py ########## @@ -259,21 +269,31 @@ def is_source_to_cache_changed( # The computation of extract_unbounded_source_signature is expensive, track on # change by default. if is_changed and update_cached_source_signature: - if ie.current_env().options.enable_capture_replay: - # TODO(BEAM-8335): display rather than logging when is_in_notebook. + options = ie.current_env().options + # No info needed when capture replay is disabled. + if options.enable_capture_replay: + + def sizeof_fmt(num, suffix='B'): Review comment: Should this be moved inside the if below? Is it used anywhere else? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
