iemejia commented on a change in pull request #11046: [BEAM-9442] Properly
handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388257264
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##########
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation
valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+ public int reserveSlot() {
Review comment:
nit: (slightly related to this PR) can we make `SelectByteBuddyHelpers`
package private please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
