mxm commented on a change in pull request #11051: [BEAM-9448] Fix log message
for job server cache.
URL: https://github.com/apache/beam/pull/11051#discussion_r388323826
##########
File path: sdks/python/apache_beam/utils/subprocess_server.py
##########
@@ -194,9 +194,11 @@ def local_jar(cls, url):
if os.path.exists(url):
return url
else:
- _LOGGER.warning('Downloading job server jar from %s' % url)
cached_jar = os.path.join(cls.JAR_CACHE, os.path.basename(url))
- if not os.path.exists(cached_jar):
+ if os.path.exists(cached_jar):
+ _LOGGER.warning('Using cached job server jar from %s' % url)
+ else:
+ _LOGGER.warning('Downloading job server jar from %s' % url)
Review comment:
Should this really be WARN? IMHO info would suffice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
