alexvanboxel commented on issue #10413: [BEAM-9035] Typed options for Row Schema and Field URL: https://github.com/apache/beam/pull/10413#issuecomment-595290187 @reuvenlax the fixup addresses the following issues: * map<string,Option> -> repeated option * removed setters, except setOption and setRowOption (kept getters though) * throw IllegalArgument when option is null Answered: * SchemaVerification needed to be pullout out of row, used for Row and **now** Option validation * array/iterableValueFromProto same, but getElementList is not a shared method (different class, same method name)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
