TheNeuralBit commented on a change in pull request #10757: Starting implementation of dataframes for Beam URL: https://github.com/apache/beam/pull/10757#discussion_r389128656
########## File path: sdks/python/apache_beam/dataframe/frames_test.py ########## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import unittest + +import numpy as np +import pandas as pd + +from apache_beam.dataframe import expressions +from apache_beam.dataframe import frame_base +from apache_beam.dataframe import frames Review comment: It doesn't look like this import is actually used in this file. Given how closely related `frame` and `frame_base` are, I wonder if they should just be combined? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
