kamilwu commented on issue #11092: [BEAM-9085] Fix performance regression in SyntheticSource URL: https://github.com/apache/beam/pull/11092#issuecomment-597180032 R: @tvalentyn I did many tests and gathered the results in one single document: https://docs.google.com/document/d/1AegjUCc5w4B90_rvR8WAfIeL65PHUi4oGYkodgPS0o0/edit?usp=sharing. The previous solution (https://github.com/apache/beam/pull/10885) didn't work very well on big `element_size`, which was most probably the cause of failures and slowdowns. Although this PR is still a bit slower than we have now using numpy 1.16 and Python 2.7, I'd rather avoid downgrading numpy via supplying an additional requirements.txt file to a Dataflow job. According to this document (https://numpy.org/neps/nep-0029-deprecation_policy.html), the support for numpy 1.16 will be dropped on Jan 13, 2021 - and this looks like a temporary solution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
