lukecwik commented on issue #11093: Exclude signature files from expansion service test dependencies URL: https://github.com/apache/beam/pull/11093#issuecomment-597199629 You > > Note that this is a problem in SQL as well for the shadowJar and the testShadowJar: > > I was under the impression that SQL was ok because it uses `shadowJar` directly. But I'll admit I'm not well versed in how all this works. I'll look into whether we're pulling in signatures in the sql jars. Even if you may not be pulling them in right now, you may start pulling them in the future with a dependency change. Also, there are other flags that should be set like zip64. Take a look at the shadowJar and shadowTestJar tasks in BeamModulePlugin.groovy
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
