tweise commented on a change in pull request #11084: [BEAM-9474] Improve
robustness of BundleFactory and ProcessEnvironment
URL: https://github.com/apache/beam/pull/11084#discussion_r390477363
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -375,6 +428,11 @@ public RemoteBundle getBundle(
}
}
+ // Ensure client is referenced for this bundle, unref in close()
+ client.ref();
+ // Cleanup list of clients which were active during eviction but now do
not hold references
+ evictedActiveClients.removeIf(c -> c.bundleRefCount.get() <= 0);
Review comment:
I'm not sure I like this in the path for every bundle. We could probably
move it below line 416 (`preparedClients.keySet().removeIf(c ->
c.bundleRefCount.get() <= 0);`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
