mxm commented on a change in pull request #11108: [BEAM-9490] Guard referencing
for environment expiration via a lock
URL: https://github.com/apache/beam/pull/11108#discussion_r391752678
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -192,6 +202,28 @@ public static DefaultJobBundleFactory create(
ImmutableList.Builder<LoadingCache<Environment, WrappedSdkHarnessClient>>
caches =
ImmutableList.builder();
for (int i = 0; i < count; i++) {
+ final Lock refLock = environmentCacheLocks.get(i);
+ builder = builder.removalListener(
+ notification -> {
+ WrappedSdkHarnessClient client = (WrappedSdkHarnessClient)
notification.getValue();
Review comment:
This is resolved now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
