pabloem commented on a change in pull request #11109: [BEAM-8335] Final PR to 
merge the InteractiveBeam feature branch
URL: https://github.com/apache/beam/pull/11109#discussion_r391981709
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
 ##########
 @@ -314,6 +327,26 @@ def show(*pcolls, **configs):
   bcj.attempt_to_run_background_caching_job(
       runner, user_pipeline, user_pipeline.options)
 
+  pcolls = set(pcolls)
+  computed_pcolls = set()
+  for pcoll in pcolls:
+    if pcoll in ie.current_env().computed_pcollections:
 
 Review comment:
   so for streaming pipelines that don't cache data, this will never finish. is 
that correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to