jfarr commented on a change in pull request #9758: [BEAM-8374] Enable returning
missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#discussion_r392519864
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/sns/SnsCoderProviderRegistrar.java
##########
@@ -32,6 +32,7 @@
@Override
public List<CoderProvider> getCoderProviders() {
return ImmutableList.of(
- CoderProviders.forCoder(TypeDescriptor.of(PublishResult.class),
PublishResultCoder.of()));
+ CoderProviders.forCoder(
+ TypeDescriptor.of(PublishResult.class),
PublishResultCoders.defaultPublishResult()));
Review comment:
It's sort of the same reason as above, PublishResultCoders is a factory for
creating several different coder implementations so the factory methods have
different names to indicate which one. I could rename this method to `of()` but
since we are introducing new behavior I wanted to make it very clear that this
is the default, or existing, behavior. Also I'm not sure if it makes sense to
have a method called `of()` on the factory not on the coder itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
