lgajowy commented on a change in pull request #11135: Add spark structured
streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392852028
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy
##########
@@ -79,7 +79,23 @@ def smokeTestConfigurations = { datasetName -> [
fanout : 10,
iterations : 1,
]
+ ],
Review comment:
I'm not really sure if "smoke" tests are used by anyone tbh. If not, I
wouldn't bother adding new scenarios here and propose to create an issue to
remove smoke tests (unused code, unused jobs). If however they are used then
pls ignore this comment :)
@mwalenia could you confirm what is the case here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
