KevinGG edited a comment on issue #11138: [BEAM-8335] Refactor IPythonLogHandler
URL: https://github.com/apache/beam/pull/11138#issuecomment-599743020
 
 
   Formatted.
   Lint has passed locally.
   
   The change is mainly moving `register_log_handler` from 
`utils.interactive_utils` to `runners.interactive.utils`.
   
   The logic change is to use `record.msg % record.args` as the message instead 
of just `record.msg`.
   
   Together with some minor fixes.
   
   R: @pabloem 
   R: @davidyan74 
   R: @rohdesamuel 
   
   PTAL, thx!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to