Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#issuecomment-599871035 > In general, it's preferable to avoid checking in script-created files, preferring instead to create them on demand at build time. (There are exceptions, e.g. bootstrapping and/or difficult to obtain build tools, but I don't think that applies here.) > > As another principle, it's preferable, where possible, to enforce correctness of the repository state before things get committed/merged (e.g. at pre-commit time), rather than have a separate, asynchronous, external process to try to fix things up after the fact. > > Perhaps it's worth expanding the design doc on how we could do this? Yep, I will add it to the doc and send out for review when it is ready. Thanks for explanation!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
