lukecwik commented on a change in pull request #11156: [BEAM-9444] Use GCP
Libraries BOM for Google Cloud Dependencies
URL: https://github.com/apache/beam/pull/11156#discussion_r394484244
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1274,7 +1296,9 @@ class BeamModulePlugin implements Plugin<Project> {
// has different dependencies than our project.
if (config.getName() != "errorprone" && !inDependencyUpdates) {
config.resolutionStrategy {
- force project.library.java.values()
+ // Filtering versionless coordinates that depend on BOM
+ def librariesWithVersion = project.library.java.values().findAll {
it.split(':').size() > 2 }
+ force librariesWithVersion
Review comment:
> > to increase the compatibility across multiple Beam modules
>
> That increased compatibility only affects Beam's build time. Not for Beam
users who consume Beam's Maven artifacts. (Correct me if I'm wrong)
Yes, that is my understanding as well.
> > How would the BOM interact with the force if it stayed or if it was
removed?
>
> The question whether force is not directly relevant to the BOM (although
artifacts that rely on the BOM do not have versions in this file, therefore
cannot be used with `force`)
Would it be wise to enumerate all the artifacts in the BOM and `force` their
resolution?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
