pabloem commented on a change in pull request #11128: [BEAM-9524] Fix for
ib.show() executing indefinitely
URL: https://github.com/apache/beam/pull/11128#discussion_r394648905
##########
File path:
sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
##########
@@ -153,7 +153,8 @@ def __init__(
self._coder = coder
self._labels = labels
self._is_cache_complete = (
- is_cache_complete if is_cache_complete else lambda: True)
+ is_cache_complete if is_cache_complete else lambda _: True)
+ self._pipeline_id = labels[-1].split('_')[-1]
Review comment:
Will it come in as a label?
the ID will be unique for the pipeline object itself. I guess we will not be
reusing it anywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services