ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow
artifacts from environment
URL: https://github.com/apache/beam/pull/11039#discussion_r394722832
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -752,6 +759,27 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
}
}
+ private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ ImmutableList.Builder<String> filesToStageBuilder =
ImmutableList.builder();
+ for (Map.Entry<String, RunnerApi.Environment> entry :
+ pipeline.getComponents().getEnvironmentsMap().entrySet()) {
+ for (RunnerApi.ArtifactInformation info :
entry.getValue().getDependenciesList()) {
+ if
(!BeamUrns.getUrn(RunnerApi.StandardArtifacts.Types.FILE).equals(info.getTypeUrn()))
{
Review comment:
Currently, DataflowRunner auto-generates staging names based on source file
names. So ROLE (STAGING_TO) is ignored anyway. We could change this behavior
later in BEAM-9455.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
