alexvanboxel commented on issue #11074: Store logical type values in Row 
instead of base values
URL: https://github.com/apache/beam/pull/11074#issuecomment-601111384
 
 
   > @alexvanboxel this will conflict badly with your PR I think (as you moved 
code into a new file, which makes merges tricky) so we need to be quite careful 
with how we merge these PRs.
   
   No more comment, I like the consistency. We're using some logical types into 
our pipelines, so I will make a custom build before the release to see if all 
goes well.
   
   I've merged my PR onto master as soon as I saw the LGTM, so I think the 
easiest thing is to rebase this branch onto master and handle the schema 
conflicts. I'll review as soon as this is done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to