tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom 
BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r395422570
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
 ##########
 @@ -236,11 +251,12 @@ def create_table(cls, table_name):
     cls.bigquery_client.insert_rows(
         cls.project, cls.dataset_id, table_name, table_data)
 
-  def get_expected_data(self):
+  def get_expected_data(self, native=True):
+    byts = b'\xab\xac'
     expected_row = {
         'float': 0.33,
         'numeric': Decimal('10'),
-        'bytes': base64.b64encode(b'\xab\xac'),
+        'bytes': base64.b64encode(byts) if native else byts,
 
 Review comment:
   How intuitive will this behavior be to users? should't the output be 
consistent? 
   If we decide to keep it, how will this be documented?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to