lukecwik commented on a change in pull request #11177: [BEAM-9562] Add Timer to
Elements proto representation.
URL: https://github.com/apache/beam/pull/11177#discussion_r395426301
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -533,8 +538,33 @@ message Elements {
bytes data = 3;
}
+ // Represent the encoded user timer for a given instruction, transform and
+ // timer id.
+ message Timer {
+ // (Required) A reference to an active instruction request with the given
+ // instruction id.
+ string instruction_id = 1;
+ // (Required) A definition representing a consumer or producer of this
data.
+ // If received by a harness, this represents the consumer within that
+ // harness that should consume these bytes. If sent by a harness, this
+ // represents the producer of these bytes.
Review comment:
```suggestion
// harness that should consume these timers. If sent by a harness, this
// represents the producer of these timers.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
