lostluck commented on a change in pull request #11179: [BEAM-3301] Bugfix in
DoFn validation.
URL: https://github.com/apache/beam/pull/11179#discussion_r395838378
##########
File path: sdks/go/pkg/beam/pcollection.go
##########
@@ -60,6 +60,12 @@ func (p PCollection) Type() FullType {
return p.n.Type()
}
+// OutputsKV returns whether the output of this PCollection are single value
+// elements or KV pairs.
+func (p PCollection) OutputsKV() bool {
Review comment:
That's my usual guideline. If I use it once, keep it in place; twice, copy
it; three times, helper function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
