reuvenlax commented on a change in pull request #10529: [BEAM-9044] Protobuf
options to Schema options
URL: https://github.com/apache/beam/pull/10529#discussion_r396253168
##########
File path:
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java
##########
@@ -205,10 +205,12 @@ static Schema getSchema(Descriptors.Descriptor
descriptor) {
// Store proto field number in metadata.
FieldType fieldType =
withMetaData(beamFieldTypeFromProtoField(fieldDescriptor),
fieldDescriptor);
Review comment:
We want to switch this metadata to use options. However you are translating
proto option names directly to field names, which means there's no guarantee
that these other options won't conflict. Maybe prefix all of these options with
something to prevent potential conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
