aaltay commented on a change in pull request #11156: [BEAM-9444] Use GCP
Libraries BOM for Google Cloud Dependencies
URL: https://github.com/apache/beam/pull/11156#discussion_r396593515
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -444,45 +439,46 @@ class BeamModulePlugin implements Plugin<Project> {
commons_lang3 :
"org.apache.commons:commons-lang3:3.9",
commons_math3 :
"org.apache.commons:commons-math3:3.6.1",
error_prone_annotations :
"com.google.errorprone:error_prone_annotations:2.0.15",
- gax :
"com.google.api:gax:$gax_version",
- gax_grpc :
"com.google.api:gax-grpc:$gax_version",
+ gax : "com.google.api:gax",
+ gax_grpc :
"com.google.api:gax-grpc",
google_api_client :
"com.google.api-client:google-api-client:$google_clients_version",
google_api_client_jackson2 :
"com.google.api-client:google-api-client-jackson2:$google_clients_version",
google_api_client_java6 :
"com.google.api-client:google-api-client-java6:$google_clients_version",
- google_api_common :
"com.google.api:api-common:1.8.1",
+ google_api_common :
"com.google.api:api-common",
Review comment:
OK, this is good.
- For easy access could we link to that dashboard from the place we are
including the bom in BeamModulePlugin.groovy
One clarification question. Beam will depend on that exact list of
dependencies shown in that dashboard. Is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
