steveniemitz commented on a change in pull request #11154: [BEAM-1819] Key
should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r396604278
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -1155,6 +1156,10 @@ public Instant getStateStartTime() {
// Note that TimerOrElementCoder is a backwards-compatibility class
// that is really a FakeKeyedWorkItemCoder
Coder<?> valueCoder = ((WindowedValueCoder<?>) readCoder).getValueCoder();
+
+ if (valueCoder instanceof KvCoder<?, ?>) {
+ return ((KvCoder<?, ?>) valueCoder).getKeyCoder();
+ }
Review comment:
without it, the key passed into the `WindmillStateInternals` constructor is
always null. This coder is used to deserialize the user key from the work item
key here:
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java#L1340
It doesn't look like it was ever really used before other than for debug
messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
