chadrik commented on a change in pull request #11038: [BEAM-7746] More typing
fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r396693751
##########
File path: sdks/python/mypy.ini
##########
@@ -17,16 +17,21 @@
[mypy]
python_version = 3.6
+files = apache_beam
ignore_missing_imports = true
-follow_imports = true
-warn_no_return = true
no_implicit_optional = true
+# warnings:
+warn_no_return = true
warn_redundant_casts = true
warn_unused_ignores = true
+# formatting:
show_error_codes = true
-files = apache_beam
color_output = true
-# uncomment this to see how close we are to being complete
+# required setting for dmypy:
+follow_imports = error
Review comment:
mypy picks up the site-packages directory of the python that it's installed
into. Only PEP 561 compliant packages will inform the type analysis (i.e. the
package must have a `py.typed` file). Alternately, you can specify the
interpreter for finding site-packages with `--python-executable`:
```
--python-executable EXECUTABLE
Python executable used for finding PEP 561
compliant installed packages and stubs
```
This config change did not generate any additional errors for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
