davidyan74 commented on a change in pull request #11198: [BEAM-7923] Obfuscates
display ids
URL: https://github.com/apache/beam/pull/11198#discussion_r396717186
##########
File path:
sdks/python/apache_beam/runners/interactive/display/pcoll_visualization.py
##########
@@ -246,11 +247,11 @@ def __init__(self, pcoll, include_window_info=False,
display_facets=False):
if not self._pcoll_var:
self._pcoll_var = 'Value'
self._cache_key = self._pin.cache_key(self._pcoll)
- self._dive_display_id = 'facets_dive_{}_{}'.format(
- self._cache_key, id(self))
- self._overview_display_id = 'facets_overview_{}_{}'.format(
- self._cache_key, id(self))
- self._df_display_id = 'df_{}_{}'.format(self._cache_key, id(self))
+ self._dive_display_id = 'facets_dive_{}'.format(
+ obfuscate(self._cache_key, id(self)))
Review comment:
nit: assign the obfuscate return value to a variable so it can be reused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
