alexvanboxel commented on a change in pull request #10529: [BEAM-9044] Protobuf
options to Schema options
URL: https://github.com/apache/beam/pull/10529#discussion_r396977813
##########
File path:
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java
##########
@@ -205,10 +205,12 @@ static Schema getSchema(Descriptors.Descriptor
descriptor) {
// Store proto field number in metadata.
FieldType fieldType =
withMetaData(beamFieldTypeFromProtoField(fieldDescriptor),
fieldDescriptor);
Review comment:
Is it, I don't think so... because I told Reuven I would do metadata after
this. Still I think it's a good idea... and with your comment I want to revise
the URI:
- `beam:option:proto:field:vptech.data.v1.description` for a proto field
option
- `beam:option:proto:message:vptech.data.v1.description` for a proto message
option
- `beam:option:proto:meta:number` for a proto field number
- `beam:option:proto:meta:type_name` for a proto type name
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
