[beam] branch master updated: [BEAM-10379] Remove BIT_XOR from ZetaSQL supported functions list.

[ibzib]

This is an automated email from the ASF dual-hosted git repository.

ibzib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 4ea3602  [BEAM-10379] Remove BIT_XOR from ZetaSQL supported functions 
list.
     new 41bd965  Merge pull request #13866 from ibzib/xor-rollback
4ea3602 is described below

commit 4ea3602dc9183327174ced07a0ad779888449918
Author: Kyle Weaver <kcwea...@google.com>
AuthorDate: Mon Feb 1 11:12:16 2021 -0800

    [BEAM-10379] Remove BIT_XOR from ZetaSQL supported functions list.
    
    It does not pass internal compliance tests because nulls are not propagated 
correctly.
---
 .../sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java   | 3 ++-
 .../apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
 
b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
index 59f01b1..8680c38 100644
--- 
a/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
+++ 
b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
@@ -415,7 +415,8 @@ class SupportedZetaSqlBuiltinFunctions {
           // JIRA link: https://issues.apache.org/jira/browse/BEAM-10379
           // FunctionSignatureId.FN_BIT_AND_INT64, // bit_and
           FunctionSignatureId.FN_BIT_OR_INT64, // bit_or
-          FunctionSignatureId.FN_BIT_XOR_INT64, // bit_xor
+          // TODO(BEAM-10379) Re-enable when nulls are handled properly.
+          // FunctionSignatureId.FN_BIT_XOR_INT64, // bit_xor
           // FunctionSignatureId.FN_LOGICAL_AND, // logical_and
           // FunctionSignatureId.FN_LOGICAL_OR, // logical_or
           // Approximate aggregate functions.
diff --git 
a/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
 
b/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
index dcf21bb..9f5bd28 100644
--- 
a/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
+++ 
b/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlDialectSpecTest.java
@@ -4069,6 +4069,8 @@ public class ZetaSqlDialectSpecTest extends 
ZetaSqlTestBase {
   }
 
   @Test
+  @Ignore(
+      "Null values are not handled properly, so BIT_XOR is temporarily removed 
from SupportedZetaSqlBuiltinFunctions. 
https://issues.apache.org/jira/browse/BEAM-10379";)
   public void testZetaSQLBitXor() {
     String sql = "SELECT BIT_XOR(x) AS bit_xor FROM UNNEST([5678, 1234]) AS x";
     ZetaSQLQueryPlanner zetaSQLQueryPlanner = new ZetaSQLQueryPlanner(config);