This is an automated email from the ASF dual-hosted git repository.
heejong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new e959d62 Fixes a case where BigQuery sink swallows HttpErrors
preventing retries.
new d221125 Merge pull request #14837 from chamikaramj/bq_empty_error
e959d62 is described below
commit e959d621c1553a556eea8ed0b6bc9e27bd0452ac
Author: Chamikara Jayalath <[email protected]>
AuthorDate: Tue May 18 15:06:12 2021 -0700
Fixes a case where BigQuery sink swallows HttpErrors preventing retries.
---
sdks/python/apache_beam/io/gcp/bigquery_tools.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sdks/python/apache_beam/io/gcp/bigquery_tools.py
b/sdks/python/apache_beam/io/gcp/bigquery_tools.py
index ad0b830..e1d310d 100644
--- a/sdks/python/apache_beam/io/gcp/bigquery_tools.py
+++ b/sdks/python/apache_beam/io/gcp/bigquery_tools.py
@@ -642,6 +642,9 @@ class BigQueryWrapper(object):
service_call_metric.call(error.reason)
except HttpError as e:
service_call_metric.call(e)
+
+ # Re-reise the exception so that we re-try appropriately.
+ raise
finally:
self._latency_histogram_metric.update(
int(time.time() * 1000) - started_millis)