[beam] branch master updated: [BEAM-13313] Fix WindowingStrategy proto to use snake case field names.

[ibzib]

This is an automated email from the ASF dual-hosted git repository.

ibzib pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new a92bc09  [BEAM-13313] Fix WindowingStrategy proto to use snake case 
field names.
     new e51c7a2  Merge pull request #16054 from lukecwik/beam13313
a92bc09 is described below

commit a92bc0922afa3ccc03426b304261c06294f06c63
Author: Luke Cwik <lc...@google.com>
AuthorDate: Tue Nov 23 13:36:46 2021 -0800

    [BEAM-13313] Fix WindowingStrategy proto to use snake case field names.
    
    Also update the one usage within Python.
    Go and Java convert snake case to camel case method names so they didn't 
have to change.
---
 model/pipeline/src/main/proto/beam_runner_api.proto | 2 +-
 sdks/python/apache_beam/transforms/core.py          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/model/pipeline/src/main/proto/beam_runner_api.proto 
b/model/pipeline/src/main/proto/beam_runner_api.proto
index 3c649bf..aaeb9da 100644
--- a/model/pipeline/src/main/proto/beam_runner_api.proto
+++ b/model/pipeline/src/main/proto/beam_runner_api.proto
@@ -1095,7 +1095,7 @@ message WindowingStrategy {
   int64 allowed_lateness = 8;
 
   // (Required) Indicate whether empty on-time panes should be omitted.
-  OnTimeBehavior.Enum OnTimeBehavior = 9;
+  OnTimeBehavior.Enum on_time_behavior = 9;
 
   // (Required) Whether or not the window fn assigns inputs to exactly one 
window
   //
diff --git a/sdks/python/apache_beam/transforms/core.py 
b/sdks/python/apache_beam/transforms/core.py
index 0038a85..bd999f8 100644
--- a/sdks/python/apache_beam/transforms/core.py
+++ b/sdks/python/apache_beam/transforms/core.py
@@ -2981,7 +2981,7 @@ class Windowing(object):
         output_time=self.timestamp_combiner,
         # TODO(robertwb): Support EMIT_IF_NONEMPTY
         closing_behavior=beam_runner_api_pb2.ClosingBehavior.EMIT_ALWAYS,
-        OnTimeBehavior=beam_runner_api_pb2.OnTimeBehavior.FIRE_ALWAYS,
+        on_time_behavior=beam_runner_api_pb2.OnTimeBehavior.FIRE_ALWAYS,
         allowed_lateness=self.allowed_lateness.micros // 1000,
         environment_id=environment_id)