This is an automated email from the ASF dual-hosted git repository.
lostluck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new b9c6ed9cb72 [BEAM-14302] Simplify boolean check in fn.go (#17399)
b9c6ed9cb72 is described below
commit b9c6ed9cb721c048b1c9a4abe317ca0c4f613221
Author: Jack McCluskey <[email protected]>
AuthorDate: Fri Apr 22 13:51:10 2022 -0400
[BEAM-14302] Simplify boolean check in fn.go (#17399)
---
sdks/go/pkg/beam/core/graph/fn.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sdks/go/pkg/beam/core/graph/fn.go
b/sdks/go/pkg/beam/core/graph/fn.go
index 95b22430350..69460ee9f4a 100644
--- a/sdks/go/pkg/beam/core/graph/fn.go
+++ b/sdks/go/pkg/beam/core/graph/fn.go
@@ -989,7 +989,7 @@ func validateWatermarkSig(fn *Fn) error {
switch name {
case createWatermarkEstimatorName:
- if
method.Ret[0].T.Implements(watermarkEstimatorT) == false {
+ if
!method.Ret[0].T.Implements(watermarkEstimatorT) {
err := errors.Errorf("invalid output
type in method %v, return %v: %v does not implement sdf.WatermarkEstimator",
createWatermarkEstimatorName,
0, method.Ret[0].T)
return errors.SetTopLevelMsgf(err,
"Invalid output type in method %v, "+
