[ 
https://issues.apache.org/jira/browse/BEAM-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174967#comment-15174967
 ] 

Kenneth Knowles commented on BEAM-85:
-------------------------------------

Another option is to make BeamAssert transparently a PTransform instead 
mimicking English prose.

{code:java}
Pipeline p = TestPipeline.create();
p.apply(... /* do things ready */ ...)
    .apply(BeamAssert.contains(/* expected */))
{code}

> DataflowAssert (BeamAssert ;) needs sanity check that it's used correctly
> -------------------------------------------------------------------------
>
>                 Key: BEAM-85
>                 URL: https://issues.apache.org/jira/browse/BEAM-85
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Davor Bonaci
>
> It is important that assert is applied to pipeline before the pipeline is 
> run, otherwise it does not actually execute the test.
> This code should throw an assertion error or fail in some other way.
> ```java
> {
> Pipeline p = TestPipeline.create();
> PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
> p.run();
> DataflowAssert.thatSingleton(value).isEqualTo(true);
> }
> ```
> but it would pass silently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to